fix: fix vector index prewarm index#5412
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
I took a quick look and the fix seems correct, but there’s an issue with index access inside nested structs. I wonder if we can improve this.
Let’s build an API called resolve_index_column(idx_meta, column_arg, schema) -> Result<(String, FieldRef)>, where the String is the full path of the given index.
The full path can be used in all following API calls like get_vector_type.
This API could be used across all vector, scalar, and generic open/prewarm operations.
What do you think?
That sounds like a good idea, let me try to improve it. |
|
@Xuanwo Address the comment, please take another look when you have time, thanks! |
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
Close lance-format#5411. First, try to retrieve the field from the schema. If it cannot be retrieved, then retrieve it directly from the fields of `index_meta`. --------- Co-authored-by: xloya <xiaojiebao@apache.org>
Close #5411. First, try to retrieve the field from the schema. If it cannot be retrieved, then retrieve it directly from the fields of
index_meta.