Skip to content

feat(blob_v2): add packed blob support#5413

Merged
Xuanwo merged 28 commits intomainfrom
xuanwo/packed-blob-plan
Dec 9, 2025
Merged

feat(blob_v2): add packed blob support#5413
Xuanwo merged 28 commits intomainfrom
xuanwo/packed-blob-plan

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Dec 5, 2025

This PR will add packed blob support for lance.

This PR is based on #5406, please review that first.


Parts of this PR were drafted with assistance from Codex (with gpt-5.1-codex-max) and fully reviewed and edited by me. I take full responsibility for all changes.

Xuanwo added 18 commits December 3, 2025 12:54
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the enhancement New feature or request label Dec 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 38.64734% with 127 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/blob.rs 0.00% 127 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo mentioned this pull request Dec 5, 2025
9 tasks
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review December 7, 2025 18:17
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/lance/src/dataset/blob.rs Outdated
Copy link
Copy Markdown
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always!

Comment thread rust/lance/src/dataset/blob.rs
Comment thread rust/lance/src/dataset/blob.rs Outdated
Comment thread rust/lance/src/dataset/blob.rs Outdated
Comment thread rust/lance/src/dataset/blob.rs Outdated
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 9bc642c into main Dec 9, 2025
27 checks passed
@Xuanwo Xuanwo deleted the xuanwo/packed-blob-plan branch December 9, 2025 14:25
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
This PR will add packed blob support for lance.

This PR is based on lance-format#5406,
please review that first.

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.1-codex-max`) and fully reviewed and edited by me. I take full
responsibility for all changes.**

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants