fix: panic unwrap on None in decoder.rs#5424
Merged
wjones127 merged 7 commits intolance-format:mainfrom Dec 12, 2025
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
requested changes
Dec 9, 2025
b639cd3 to
0ca3ab5
Compare
Contributor
Author
|
@wjones127 seems CI failed because of the other PR |
Contributor
|
This is the error: I think you may need to call |
Contributor
|
I've added the |
Contributor
Author
|
@wjones127 Thx you, I will pay more attention later |
wjones127
approved these changes
Dec 12, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Dec 16, 2025
for: lance-format#5119 --------- Co-authored-by: Will Jones <willjones127@gmail.com>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Dec 16, 2025
for: lance-format#5119 --------- Co-authored-by: Will Jones <willjones127@gmail.com>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
for: lance-format#5119 --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for: #5119