test: get some lance-core util modules to 100% coverage#5429
Merged
wjones127 merged 4 commits intolance-format:mainfrom Dec 10, 2025
Merged
test: get some lance-core util modules to 100% coverage#5429wjones127 merged 4 commits intolance-format:mainfrom
wjones127 merged 4 commits intolance-format:mainfrom
Conversation
Add unit tests for bit.rs, hash.rs, address.rs, and backoff.rs to achieve full line and branch coverage. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add documentation with doctests for public functions in bit.rs, hash.rs, and address.rs. Keep minimal unit tests for coverage since doctests aren't included in coverage reports. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Consolidate unit tests and use different test values than doctests: - Doctests: document common usage patterns - Unit tests: test different values/edge cases for coverage 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
wjones127
changed the title
wjones127
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Xuanwo
approved these changes
Dec 10, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…#5429) ## Summary - Add unit tests and doctests for `bit.rs`, `hash.rs`, `address.rs`, and `backoff.rs` - Achieve 100% line and branch coverage for these utility modules - Doctests serve as documentation examples; unit tests cover different values/edge cases ## Test plan - [x] All unit tests pass - [x] All doctests pass - [x] Coverage verified at 100% for all four files 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bit.rs,hash.rs,address.rs, andbackoff.rsTest plan
🤖 Generated with Claude Code