test: achieve 100% test coverage for lance-arrow json module#5430
Merged
wjones127 merged 1 commit intolance-format:mainfrom Dec 10, 2025
Merged
test: achieve 100% test coverage for lance-arrow json module#5430wjones127 merged 1 commit intolance-format:mainfrom
wjones127 merged 1 commit intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wjones127
changed the title
- Add 24 new tests covering all functions and branches - Simplify decode_json to return String (can't fail) - Simplify to_arrow_json to return ArrayRef directly - Replace unreachable error handling with expect() for type-checked downcasts - Simplify get_json_path using the ? operator 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wjones127
force-pushed
the
json-coverage-100
branch
from
9f684ac to
36fc5d4
Compare
Xuanwo
approved these changes
Dec 10, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ormat#5430) ## Summary - Add 24 new tests covering all functions and branches in `lance-arrow/src/json.rs` - Simplify `decode_json` to return `String` directly (can't fail) - Simplify `to_arrow_json` to return `ArrayRef` directly - Replace unreachable error handling with `expect()` for type-checked downcasts - Simplify `get_json_path` using the `?` operator ## Test plan - [x] All 37 json module tests pass - [x] Verified 100% line/branch/function/region coverage via `cargo +nightly llvm-cov` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lance-arrow/src/json.rsdecode_jsonto returnStringdirectly (can't fail)to_arrow_jsonto returnArrayRefdirectlyexpect()for type-checked downcastsget_json_pathusing the?operatorTest plan
cargo +nightly llvm-cov🤖 Generated with Claude Code