test: use cheaper builds for profiling#5436
Merged
westonpace merged 1 commit intolance-format:mainfrom Dec 8, 2025
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Xuanwo
approved these changes
Dec 8, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
Running `cargo bench` is incredibly expensive, especially in higher level crates like `lance`. Since we aren't actually creating release builds and more interested in trends and investigation (we aren't doing any comparative benchmarking at this level) I think it is ok to use a slightly less optimized profile for building.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
cargo benchis incredibly expensive, especially in higher level crates likelance. Since we aren't actually creating release builds and more interested in trends and investigation (we aren't doing any comparative benchmarking at this level) I think it is ok to use a slightly less optimized profile for building.