Skip to content

feat(blob_v2): add BlobAray API for user input#5451

Merged
Xuanwo merged 12 commits intomainfrom
xuanwo/blob-v2-api
Dec 12, 2025
Merged

feat(blob_v2): add BlobAray API for user input#5451
Xuanwo merged 12 commits intomainfrom
xuanwo/blob-v2-api

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Dec 10, 2025

This PR will add BlobAray API for user input so that they don't need to play with metadata by themselves.


Parts of this PR were drafted with assistance from Codex (with gpt-5.1-codex-max) and fully reviewed and edited by me. I take full responsibility for all changes.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@github-actions github-actions Bot added the enhancement New feature or request label Dec 10, 2025
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/lance-file/src/writer.rs
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from westonpace December 11, 2025 10:34
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 87.56477% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-core/src/datatypes/field.rs 50.00% 11 Missing and 2 partials ⚠️
rust/lance/src/blob.rs 91.60% 8 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial comments

Comment thread rust/lance-core/src/datatypes/field.rs Outdated
Comment thread rust/lance-core/src/datatypes/field.rs Outdated
Comment thread rust/lance/src/blob.rs Outdated
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 2b826a4 into main Dec 12, 2025
28 checks passed
@Xuanwo Xuanwo deleted the xuanwo/blob-v2-api branch December 12, 2025 14:38
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
This PR will add BlobAray API for user input so that they don't need to
play with metadata by themselves.

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.1-codex-max`) and fully reviewed and edited by me. I take full
responsibility for all changes.**

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants