docs: fix and improve the description about row id#5463
Merged
wjones127 merged 7 commits intolance-format:mainfrom Dec 15, 2025
Merged
docs: fix and improve the description about row id#5463wjones127 merged 7 commits intolance-format:mainfrom
wjones127 merged 7 commits intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
github-actions
Bot
added
the
documentation
wjones127
reviewed
Dec 12, 2025
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
Thanks for working on this. Have a few minor comments.
wjones127
changed the title
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Will Jones <willjones127@gmail.com>
Collaborator
Author
|
@wjones127, I have addressed the comments. Please take a look. |
Henry-LTA
reviewed
Dec 15, 2025
|
|
||
| Each row tracks the version at which it was last modified. | ||
| When a row is created, `last_updated_at_version` equals `created_at_version`. | ||
| When a row is updated, a new row is created with both `created_at_version` and `last_updated_at_version` set to the current version, and the old row is marked deleted. |
There was a problem hiding this comment.
Seems like the old row only marked deleted, not modify the last_updated_at_version?
Collaborator
Author
There was a problem hiding this comment.
yes, if we enable the stable row ID feature, when updating, the old row is only marked deleted, and the last_updated_at_version will be tracked in the new fragment for the same row id.
wjones127
approved these changes
Dec 15, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
There are some misunderstood for users about the `row ID` in the doc. See: lance-format#4935 (comment) This PR tries to correct and improve it. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some misunderstood for users about the
row IDin the doc. See: #4935 (comment)This PR tries to correct and improve it.