fix: dir namespace cloud storage path removes one subdir level#5464
Merged
jackye1995 merged 1 commit intolance-format:mainfrom Dec 12, 2025
Merged
fix: dir namespace cloud storage path removes one subdir level#5464jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995 merged 1 commit intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
LuQQiu
approved these changes
Dec 12, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jackye1995
added a commit
to lance-format/lance-spark
that referenced
this pull request
Dec 12, 2025
This contains fix to directory namespace error with cloud storage path lance-format/lance#5464
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Dec 16, 2025
…-format#5464) We use `uri_to_url` to convert a root location to `Url` and then add table subpath in dir namespace. This causes issue because there is no trailing slash for the `uri`, and `Url::join` would treat the last part of the path as a file, so joining it with another file would cause the last part of the sub directory to be ignored. This PR ensures that we add a trailing slash to the url. `uri_to_url` is used all over the place to convert root paths, so far no place do `join` after the conversion except for dir namespace, so there is no impact on other places. But I think a more comprehensive fix would be to ensure a trailing slash in the function directly, but it will be a fix that affects more places so will do it later after examining all the use cases more carefully.
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…-format#5464) We use `uri_to_url` to convert a root location to `Url` and then add table subpath in dir namespace. This causes issue because there is no trailing slash for the `uri`, and `Url::join` would treat the last part of the path as a file, so joining it with another file would cause the last part of the sub directory to be ignored. This PR ensures that we add a trailing slash to the url. `uri_to_url` is used all over the place to convert root paths, so far no place do `join` after the conversion except for dir namespace, so there is no impact on other places. But I think a more comprehensive fix would be to ensure a trailing slash in the function directly, but it will be a fix that affects more places so will do it later after examining all the use cases more carefully.
jiaoew1991
pushed a commit
to jiaoew1991/lance-spark
that referenced
this pull request
Feb 25, 2026
This contains fix to directory namespace error with cloud storage path lance-format/lance#5464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
uri_to_urlto convert a root location toUrland then add table subpath in dir namespace. This causes issue because there is no trailing slash for theuri, andUrl::joinwould treat the last part of the path as a file, so joining it with another file would cause the last part of the sub directory to be ignored.This PR ensures that we add a trailing slash to the url.
uri_to_urlis used all over the place to convert root paths, so far no place dojoinafter the conversion except for dir namespace, so there is no impact on other places. But I think a more comprehensive fix would be to ensure a trailing slash in the function directly, but it will be a fix that affects more places so will do it later after examining all the use cases more carefully.