refactor: add store_prefix to lance-io's ObjectStore#5468
refactor: add store_prefix to lance-io's ObjectStore#5468westonpace merged 5 commits intolance-format:mainfrom
Conversation
Add the store_prefix to lance-io's ObjectStore. This is helpful when caching ObjectStore objects, so that we can tell which ones map to the same data.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
westonpace
left a comment
There was a problem hiding this comment.
This seems reasonable to me. This object is somewhat indecisive between using public properties (list_is_lexically_ordered, use_constant_size_upload_parts) and accessors (block_size, max_iop_size) so I guess both approaches are fine 😆
|
Seems tests case around the following failed, maybe worth another look, cc @cmccabe |
|
Should be fixed now. I added a fallback path for object stores that aren't in the registry but that's we're "wrapping" via the deprecated API. For those we have to guess the storage prefix, unfortunately, since nothing can tell us about it. It should be OK to just use scheme+authority there. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Add the store_prefix to lance-io's ObjectStore. This is helpful when caching ObjectStore objects, so that we can tell which ones map to the same data.
Add the store_prefix to lance-io's ObjectStore. This is helpful when caching ObjectStore objects, so that we can tell which ones map to the same data.
Add the store_prefix to lance-io's ObjectStore. This is helpful when caching ObjectStore objects, so that we can tell which ones map to the same data.