Skip to content

feat: support dropping sub-column of list(struct)#5469

Merged
yanghua merged 2 commits intolance-format:mainfrom
wojiaodoubao:remove-sub-column
Jan 8, 2026
Merged

feat: support dropping sub-column of list(struct)#5469
yanghua merged 2 commits intolance-format:mainfrom
wojiaodoubao:remove-sub-column

Conversation

@wojiaodoubao
Copy link
Copy Markdown
Contributor

Drop sub-column people.item.city from dataset.

Table Schema
-id: int32
-people: struct
  -item: list(struct)
    - name: utf8
    - age: int32
    - city: utf8

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions github-actions Bot added the enhancement New feature or request label Dec 14, 2025
@wojiaodoubao wojiaodoubao changed the title feat: support dropping nested sub-column feat: support dropping sub-column of list(struct) Dec 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 92.79279% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset/schema_evolution.rs 92.38% 5 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Hi @jackye1995 , could you help review this when you have time, thanks very much!

@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Hi @jackye1995 , sorry to bother, could you help review when you have time, thanks a lot~

@wojiaodoubao
Copy link
Copy Markdown
Contributor Author

Hi @jackye1995 , could you help review this when you have time, thanks very much~

Comment thread rust/lance-core/src/datatypes/schema.rs
Comment thread rust/lance/src/dataset/schema_evolution.rs
Copy link
Copy Markdown
Collaborator

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanghua yanghua merged commit f29f6cf into lance-format:main Jan 8, 2026
29 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants