Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
westonpace
approved these changes
Dec 16, 2025
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Looks good. Only suggestion is adding some logging (we should probably have this logging in the other cleanup spots too but better late than never)
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This PR adds GC support for blob v2. Part of lance-format#4947 All blob files (whether packed or dedicated) follow the same naming pattern: `data/{data_file_key}/{blob_id:08x}.blob`. These files are only referenced by `data/{data_file_key}.lance`. Therefore, we can implement GC support by checking whether the related data file is still in use. External blobs are not being considered at this stage. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds GC support for blob v2.
Part of #4947
All blob files (whether packed or dedicated) follow the same naming pattern:
data/{data_file_key}/{blob_id:08x}.blob. These files are only referenced bydata/{data_file_key}.lance. Therefore, we can implement GC support by checking whether the related data file is still in use.External blobs are not being considered at this stage.
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.