feat: add py.typed marker file#5479
Merged
Xuanwo merged 1 commit intolance-format:mainfrom Dec 16, 2025
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
jonded94
changed the title
py.typed marker filepy.typed marker file
Xuanwo
approved these changes
Dec 16, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
Hey, currently, this package is somewhat type hinted, but unfortunately, the `py.typed` marker file is missing which is a [MUST](https://typing.python.org/en/latest/spec/distributing.html#packaging-type-information) to signal that a package can be used for type hinting for type checkers such as `mypy`. Otherwise this error appears: ``` lance_ray/datasink.py:101: error: Skipping analyzing "lance": module is installed, but missing library stubs or py.typed marker [import-untyped] ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
currently, this package is somewhat type hinted, but unfortunately, the
py.typedmarker file is missing which is a MUST to signal that a package can be used for type hinting for type checkers such asmypy. Otherwise this error appears: