feat(java): simplify the use of optional in jni#5488
Merged
jackye1995 merged 1 commit intolance-format:mainfrom Dec 17, 2025
Merged
feat(java): simplify the use of optional in jni#5488jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995 merged 1 commit intolance-format:mainfrom
Conversation
Change-Id: I94ff021eefc1260ce7f4afb2cc5063c829b0c59f
ddupg
force-pushed
the
feat/java-get_optional
branch
from
e4a6a07 to
978c801
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
Author
|
Could please @LuQQiu @jackye1995 @majin1102 help review this? |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This PR made the following changes: - Unwrap java `Optional` inside `get_optional` , so the callback receives the unwrapped value instead of Optional<T> ; removes repeated get() boilerplate - Fix `inner_shallow_clone` to correctly treat the closure input - Replace `Optional` handling with `get_optional` to reduce duplication and improve readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR made the following changes:
Optionalinsideget_optional, so the callback receives the unwrapped value instead of Optional ; removes repeated get() boilerplateinner_shallow_cloneto correctly treat the closure inputOptionalhandling withget_optionalto reduce duplication and improve readability