Skip to content

fix: ensure trailing slash is normalized in rest adapter#5499

Merged
jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995:rest-adapter-trailing-slash
Dec 17, 2025
Merged

fix: ensure trailing slash is normalized in rest adapter#5499
jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995:rest-adapter-trailing-slash

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

Allow using rest adapter in lancedb testing

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@github-actions github-actions Bot added the bug Something isn't working label Dec 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-namespace-impls/src/rest_adapter.rs 97.56% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jackye1995 jackye1995 merged commit f489d95 into lance-format:main Dec 17, 2025
27 of 28 checks passed
jackye1995 added a commit to jackye1995/lance that referenced this pull request Dec 17, 2025
jackye1995 added a commit to jackye1995/lance that referenced this pull request Dec 17, 2025
jackye1995 added a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants