Skip to content

fix: head external manifest object happend 404 NotFound error #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjones127 merged 1 commit into from
Dec 17, 2025
Merged

fix: head external manifest object happend 404 NotFound error #5512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions rust/lance-table/src/io/commit/external_manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,18 @@ impl CommitHandler for ExternalManifestCommitHandler {
let (size, e_tag) = if let Some(size) = size {
(size, e_tag)
} else {
let meta = object_store.inner.head(&path).await?;
(meta.size, meta.e_tag)
match object_store.inner.head(&path).await {
Ok(meta) => (meta.size, meta.e_tag),
Err(ObjectStoreError::NotFound { .. }) => {
// there may be other threads that have finished executing finalize_manifest.
let new_location = self
.external_manifest_store
.get_manifest_location(base_path.as_ref(), version)
.await?;
return Ok(new_location);
}
Err(e) => return Err(e.into()),
}
};

let final_location = self
Expand Down
Loading