chore: clean up the residual FTS hardcode for index#5524
Merged
yanghua merged 1 commit intolance-format:mainfrom Dec 18, 2025
Merged
chore: clean up the residual FTS hardcode for index#5524yanghua merged 1 commit intolance-format:mainfrom
yanghua merged 1 commit intolance-format:mainfrom
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
yanghua
changed the title
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
yanghua
changed the title
shiyajuan123
force-pushed
the
feat-patch-clean-index
branch
from
8f32618 to
2fad67c
Compare
yanghua
approved these changes
Dec 18, 2025
Collaborator
yanghua
left a comment
yanghua
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
Collaborator
|
The failed CI may be caused by #5525. |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Dec 30, 2025
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, there were two names that mapped to the FTX index they are
INVERTED,FTS. At some time, the code has been refactored only to useINVERTED. But there are still some residualFTShardcodes that need to be cleaned.