fix: support ManifestNamingSchemeV2 with unordered object stores#5539
Merged
wjones127 merged 1 commit intolance-format:mainfrom Dec 18, 2025
Merged
fix: support ManifestNamingSchemeV2 with unordered object stores#5539wjones127 merged 1 commit intolance-format:mainfrom
wjones127 merged 1 commit intolance-format:mainfrom
Conversation
When `list_is_lexically_ordered = false` (e.g., S3 Express), the code incorrectly assumed V1 naming scheme and errored on V2 manifests. The fix tracks the scheme from the first manifest and errors on mixed schemes instead of specifically on V2. Fixes lance-format#5521 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
westonpace
approved these changes
Dec 18, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Dec 19, 2025
…ce-format#5539) ## Summary - Fix `current_manifest_path` to handle V2 naming scheme when `list_is_lexically_ordered = false` - Previously errored with "Found V2 manifest in a V1 manifest directory" on stores like S3 Express - Now tracks scheme from first manifest and errors on mixed schemes instead ## Test plan - [x] Added parameterized test `test_current_manifest_path` covering all combinations of lexical ordering and naming scheme - [x] All 81 lance-table tests pass Fixes lance-format#5521 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
wjones127
added a commit
that referenced
this pull request
Dec 19, 2025
## Summary - Fix `current_manifest_path` to handle V2 naming scheme when `list_is_lexically_ordered = false` - Previously errored with "Found V2 manifest in a V1 manifest directory" on stores like S3 Express - Now tracks scheme from first manifest and errors on mixed schemes instead ## Test plan - [x] Added parameterized test `test_current_manifest_path` covering all combinations of lexical ordering and naming scheme - [x] All 81 lance-table tests pass Fixes #5521 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Dec 30, 2025
…ce-format#5539) ## Summary - Fix `current_manifest_path` to handle V2 naming scheme when `list_is_lexically_ordered = false` - Previously errored with "Found V2 manifest in a V1 manifest directory" on stores like S3 Express - Now tracks scheme from first manifest and errors on mixed schemes instead ## Test plan - [x] Added parameterized test `test_current_manifest_path` covering all combinations of lexical ordering and naming scheme - [x] All 81 lance-table tests pass Fixes lance-format#5521 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ce-format#5539) ## Summary - Fix `current_manifest_path` to handle V2 naming scheme when `list_is_lexically_ordered = false` - Previously errored with "Found V2 manifest in a V1 manifest directory" on stores like S3 Express - Now tracks scheme from first manifest and errors on mixed schemes instead ## Test plan - [x] Added parameterized test `test_current_manifest_path` covering all combinations of lexical ordering and naming scheme - [x] All 81 lance-table tests pass Fixes lance-format#5521 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
current_manifest_pathto handle V2 naming scheme whenlist_is_lexically_ordered = falseTest plan
test_current_manifest_pathcovering all combinations of lexical ordering and naming schemeFixes #5521
🤖 Generated with Claude Code