fix: allow storage options provider without expires_at_millis#5542
Merged
jackye1995 merged 1 commit intolance-format:mainfrom Dec 18, 2025
Merged
fix: allow storage options provider without expires_at_millis#5542jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995 merged 1 commit intolance-format:mainfrom
Conversation
wjones127
approved these changes
Dec 18, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Dec 30, 2025
…format#5542) Mainly for test use cases, it might be possible to return a credential that never expires, and currently we just block the use case which is unnecessary. Also ensure that when user explicitly sets an AwsCredentialProvider in rust, it is respected instead of getting only the initial credentials and later being overwritten by the DynamicStorageOptionsCredentialProvider.
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…format#5542) Mainly for test use cases, it might be possible to return a credential that never expires, and currently we just block the use case which is unnecessary. Also ensure that when user explicitly sets an AwsCredentialProvider in rust, it is respected instead of getting only the initial credentials and later being overwritten by the DynamicStorageOptionsCredentialProvider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly for test use cases, it might be possible to return a credential that never expires, and currently we just block the use case which is unnecessary.
Also ensure that when user explicitly sets an AwsCredentialProvider in rust, it is respected instead of getting only the initial credentials and later being overwritten by the DynamicStorageOptionsCredentialProvider.