test: add coverage for large string variant in PrefixPlusCounterGenerator#5550
Merged
wjones127 merged 2 commits intolance-format:mainfrom Dec 19, 2025
Conversation
…ator The existing test only covered the is_large=false case. This commit adds test coverage for the is_large=true branch that generates LargeStringArray, bringing the test coverage to 100% for this generator. Fixes the codecov report showing missing coverage on line 1080 in rust/lance-datagen/src/generator.rs.
XuQianJin-Stars
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
PR ReviewSummary: This is a clean, focused test addition that improves coverage for the Verdict: ✅ LGTM No issues found. The test correctly exercises the |
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Dec 30, 2025
…ator (lance-format#5550) test: add coverage for large string variant in PrefixPlusCounterGenerator The existing test only covered the is_large=false case. This commit adds test coverage for the is_large=true branch that generates LargeStringArray, bringing the test coverage to 100% for this generator. Fixes the codecov report showing missing coverage on line 1080 in rust/lance-datagen/src/generator.rs. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
…ator (lance-format#5550) test: add coverage for large string variant in PrefixPlusCounterGenerator The existing test only covered the is_large=false case. This commit adds test coverage for the is_large=true branch that generates LargeStringArray, bringing the test coverage to 100% for this generator. Fixes the codecov report showing missing coverage on line 1080 in rust/lance-datagen/src/generator.rs. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add coverage for large string variant in PrefixPlusCounterGenerator
The existing test only covered the is_large=false case. This commit adds
test coverage for the is_large=true branch that generates LargeStringArray,
bringing the test coverage to 100% for this generator.
Fixes the codecov report showing missing coverage on line 1080 in
rust/lance-datagen/src/generator.rs.