perf: offload IVF partition build to CPU pool#5551
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Code ReviewSummary: This PR offloads the IVF partition build work (filtering deleted rows, batch processing, and index building) to the dedicated CPU pool using AssessmentThe change looks correct. The The computation being moved (HashSet operations, No blocking issues identified. |
Xuanwo
approved these changes
Dec 19, 2025
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Dec 30, 2025
before: <img width="683" height="44" alt="image" src="https://github.com/user-attachments/assets/3a2d6375-ef33-40b4-af65-64b6b568c78e" /> after: <img width="745" height="43" alt="image" src="https://github.com/user-attachments/assets/4c22281d-d291-47eb-bd71-faa7c4b5a100" /> This can improve HNSW indexing 30% faster, the other vector index types can also benefit from this but not such obvious Co-authored-by: Xuanwo <github@xuanwo.io>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
before: <img width="683" height="44" alt="image" src="https://github.com/user-attachments/assets/3a2d6375-ef33-40b4-af65-64b6b568c78e" /> after: <img width="745" height="43" alt="image" src="https://github.com/user-attachments/assets/4c22281d-d291-47eb-bd71-faa7c4b5a100" /> This can improve HNSW indexing 30% faster, the other vector index types can also benefit from this but not such obvious Co-authored-by: Xuanwo <github@xuanwo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:


after:
This can improve HNSW indexing 30% faster, the other vector index types can also benefit from this but not such obvious