Skip to content

chore: simplify sort line#5555

Merged
Xuanwo merged 1 commit intomainfrom
total-cmp
Dec 19, 2025
Merged

chore: simplify sort line#5555
Xuanwo merged 1 commit intomainfrom
total-cmp

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions Bot added the chore label Dec 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

LGTM ✓

The change correctly simplifies the sort by leveraging OrderedNode's existing Ord implementation (which compares by dist). This is functionally equivalent to the previous explicit partial_cmp approach but cleaner and removes the .unwrap() call.

@Xuanwo Xuanwo merged commit aed1f15 into main Dec 19, 2025
28 of 29 checks passed
@Xuanwo Xuanwo deleted the total-cmp branch December 19, 2025 15:31
wjones127 pushed a commit to wjones127/lance that referenced this pull request Dec 30, 2025
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants