Skip to content

docs: auto-build refactored namespace integrations doc#5562

Merged
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:ns-integ-docs
Dec 22, 2025
Merged

docs: auto-build refactored namespace integrations doc#5562
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:ns-integ-docs

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 commented Dec 22, 2025

Integrations are refactored to repo https://github.com/lance-format/lance-namespace-impls

Will be built to https://lance.org/format/namespace/integrations

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Dec 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

P1: Potential Build Failure - Missing Directory

The workflow copies files to docs/src/format/namespace/integrations/ but there's no step that creates this directory:

cp lance-namespace-impls/docs/src/hive2.md docs/src/format/namespace/integrations/

The docs/src/format/namespace/ folder is created by copying from lance-namespace repo, but if that repo doesn't contain an integrations/ subdirectory, the cp commands will fail.

Suggested fix: Add mkdir -p docs/src/format/namespace/integrations before the copy commands:

- name: Copy lance-namespace-impls docs
  run: |
    # Ensure the integrations directory exists
    mkdir -p docs/src/format/namespace/integrations
    
    # Copy implementation specs...

Minor: Ordering Consideration

The "Copy lance-namespace-impls docs" step should run after "Copy lance-namespace docs" since it depends on that directory structure. Currently in the diff it appears after the checkout but before the copy steps, which would fail. Please verify the final ordering in the workflow.


Otherwise the structure looks good for aggregating docs from the refactored namespace-impls repo.

@jackye1995 jackye1995 merged commit 473f1ff into lance-format:main Dec 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants