You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a skip_merge option to the FTS index build, enabling distributed/fragment-level indexing where merge is handled separately. The implementation looks solid overall. A few observations:
P1: Missing Error Handling for Partial Copy Failures
In builder.rs:318-359, if a file copy fails partway through the skip_merge path, the destination store may be left in an inconsistent state with some partition files copied but not others. Consider:
Adding cleanup logic on error, or
Documenting this as a caller responsibility
Minor Observations (not blocking):
Python docstring placement: The skip_merge parameter documentation is inserted between with_position and base_tokenizer. While functional, grouping it with other distributed indexing params (fragment_ids, index_uuid) might improve discoverability.
Test coverage is good: The test validates the happy path and verifies partition files are written correctly. Edge cases like empty partitions or error recovery could be considered for future work.
The implementation correctly handles both fresh builds and incremental indexing scenarios. The test is well-structured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.