perf: reuse zstd compressors in encoding#5598
Merged
wjones127 merged 2 commits intolance-format:mainfrom Dec 30, 2025
Merged
Conversation
Contributor
Author
|
Here is the improvement from the encoding benchmark the patch introduces: |
This adds some simple benchmarks for encoding/decoding of a string-valued column under lz4 and zstd compression. A benchmark for parallel decoding is also included.
Prior to this commit, the ZstdBufferCompressor would construct a new zstd stream encoder on every call to compress. With this change we create one compression context for the ZstdBufferCompressor, and reuse it across calls to compress. Reuse is not implemented for lz4 compression or for decompression. These were both explored but did not bring meaningful benefits over the existing code.
5df31ed to
c7320f7
Compare
wjones127
approved these changes
Dec 30, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
Prior to this commit, the ZstdBufferCompressor would construct a new zstd stream encoder on every call to compress. With this change we create one compression context for the ZstdBufferCompressor, and reuse it across calls to compress. Reuse is not implemented for lz4 compression or for decompression. These were both explored but did not bring meaningful benefits over the existing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the ZstdBufferCompressor would construct a new
zstd stream encoder on every call to compress. With this change we
create one compression context for the ZstdBufferCompressor, and reuse
it across calls to compress.
Reuse is not implemented for lz4 compression or for decompression. These
were both explored but did not bring meaningful benefits over the
existing code.