Skip to content

ci: ping lance-namespace-reqwest-client version#5610

Merged
jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995:fix-ci8
Jan 1, 2026
Merged

ci: ping lance-namespace-reqwest-client version#5610
jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995:fix-ci8

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the ci Github Action or Test issues label Jan 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 1, 2026

PR Review

P0 - Critical Bug:

There is a typo in this PR that will break the build:

-arrow-cast = "56.1"
+darrow-cast = "56.1"

The change incorrectly renames arrow-cast to darrow-cast (note the extra 'd' at the beginning). This appears to be an accidental modification. Only the lance-namespace-reqwest-client version pinning should be changed.

Please remove this unintended change before merging.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jackye1995 jackye1995 merged commit 13785c4 into lance-format:main Jan 1, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants