feat: refactor use of Error::io#5612
Conversation
wjones127
left a comment
There was a problem hiding this comment.
Thanks for starting this. I have several suggestions.
Feel free to suggest that we add or change an error type. For example, maybe we want to make a more general NotFound error that's separate from FileNotFound error.
|
@wjones127 i have resolved your suggestions, please review this pr again:) |
|
@lichuang Generally looks good. Can you get the code compiling and tests passing? Then I can do a final review. |
|
@wjones127 I have fixed compiling error, please run workflow, and review it again. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@wjones127 I have fixed the test case, let's run the workflows again. |
1 similar comment
|
@wjones127 I have fixed the test case, let's run the workflows again. |
wjones127
left a comment
There was a problem hiding this comment.
Great work! Thanks for doing this.
fix lance-format#5601 Co-authored-by: Will Jones <willjones127@gmail.com>
fix #5601