Skip to content

feat: refactor use of Error::io#5612

Merged
wjones127 merged 2 commits intolance-format:mainfrom
lichuang:issue-5601
Jan 12, 2026
Merged

feat: refactor use of Error::io#5612
wjones127 merged 2 commits intolance-format:mainfrom
lichuang:issue-5601

Conversation

@lichuang
Copy link
Copy Markdown
Contributor

@lichuang lichuang commented Jan 2, 2026

fix #5601

@github-actions github-actions Bot added enhancement New feature or request python java labels Jan 2, 2026
@wjones127 wjones127 self-assigned this Jan 2, 2026
Copy link
Copy Markdown
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. I have several suggestions.

Feel free to suggest that we add or change an error type. For example, maybe we want to make a more general NotFound error that's separate from FileNotFound error.

Comment thread rust/lance-core/src/error.rs Outdated
Comment thread rust/lance-datafusion/src/projection.rs Outdated
Comment thread rust/lance-file/src/previous/writer/mod.rs Outdated
Comment thread rust/lance-file/src/previous/writer/mod.rs Outdated
Comment thread rust/lance-file/src/previous/writer/mod.rs
Comment thread rust/lance-file/src/previous/reader.rs Outdated
Comment thread rust/lance-table/src/io/manifest.rs Outdated
Comment thread rust/lance-table/src/io/manifest.rs Outdated
@lichuang
Copy link
Copy Markdown
Contributor Author

lichuang commented Jan 6, 2026

@wjones127 i have resolved your suggestions, please review this pr again:)

@wjones127
Copy link
Copy Markdown
Contributor

@lichuang Generally looks good. Can you get the code compiling and tests passing? Then I can do a final review.

@lichuang
Copy link
Copy Markdown
Contributor Author

lichuang commented Jan 8, 2026

@wjones127 I have fixed compiling error, please run workflow, and review it again.

@lichuang
Copy link
Copy Markdown
Contributor Author

lichuang commented Jan 8, 2026

@wjones127 I have fixed the test case, let's run the workflows again.

1 similar comment
@lichuang
Copy link
Copy Markdown
Contributor Author

@wjones127 I have fixed the test case, let's run the workflows again.

Copy link
Copy Markdown
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for doing this.

@wjones127 wjones127 merged commit 3b8d65e into lance-format:main Jan 12, 2026
26 of 27 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
fix lance-format#5601

Co-authored-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review use of Error::io() to find cases where that error should be a different type

2 participants