Skip to content

refactor: introduce RowSetOps and refactor RowAddrTreeMap#5624

Merged
yanghua merged 6 commits intolance-format:mainfrom
yanghua:refactor-introduce-RowSetOps
Jan 20, 2026
Merged

refactor: introduce RowSetOps and refactor RowAddrTreeMap#5624
yanghua merged 6 commits intolance-format:mainfrom
yanghua:refactor-introduce-RowSetOps

Conversation

@yanghua
Copy link
Copy Markdown
Collaborator

@yanghua yanghua commented Jan 5, 2026

No description provided.

@lance-format lance-format deleted a comment from github-actions Bot Jan 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-core/src/utils/mask.rs 87.23% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@yanghua yanghua marked this pull request as ready for review January 6, 2026 03:30
@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Jan 6, 2026

cc @wjones127 @jackye1995

@majin1102 majin1102 assigned majin1102 and unassigned majin1102 Jan 16, 2026
@majin1102 majin1102 self-requested a review January 16, 2026 16:19
Copy link
Copy Markdown
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This refactor is cool. Just leave one comment

Comment thread rust/lance-core/src/utils/mask.rs Outdated
@yanghua yanghua force-pushed the refactor-introduce-RowSetOps branch from d3dcaa9 to 7fdb63f Compare January 17, 2026 08:51
Copy link
Copy Markdown
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@yanghua yanghua merged commit cf8de35 into lance-format:main Jan 20, 2026
29 of 30 checks passed
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants