Skip to content

feat: add parts_searched metrics for FTS#5627

Merged
BubbleCal merged 4 commits intomainfrom
yang/fts-parts-searched
Jan 6, 2026
Merged

feat: add parts_searched metrics for FTS#5627
BubbleCal merged 4 commits intomainfrom
yang/fts-parts-searched

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the enhancement New feature or request label Jan 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

PR Review: feat: add parts_searched metrics for FTS

Overall: Clean, well-implemented feature that adds partitions_searched metrics for Full-Text Search, consistent with existing KNN metrics patterns.

Issues

P1: Missing metrics recording in BooleanQueryExec

The BooleanQueryExec struct at line 906+ also uses FtsIndexMetrics but doesn't call record_parts_searched(). This creates inconsistency where some FTS query types report partition metrics and others don't. Consider adding the metric recording to BooleanQueryExec::execute() as well, or document why it's intentionally omitted.

Minor Observations

  • The test is comprehensive and validates both the metric value and its presence in the plan analysis output.
  • The implementation correctly reuses the existing PARTITIONS_SEARCHED_METRIC constant from lance_datafusion::utils, maintaining consistency with KNN indexing.

No other significant issues found.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 99.35065% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/io/exec/fts.rs 99.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@BubbleCal BubbleCal merged commit b172c19 into main Jan 6, 2026
29 checks passed
@BubbleCal BubbleCal deleted the yang/fts-parts-searched branch January 6, 2026 07:14
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants