feat: improve the random access file benchmark#5628
feat: improve the random access file benchmark#5628westonpace merged 4 commits intolance-format:mainfrom
Conversation
Code ReviewP0: Potential Bug - Compilation Failure on Non-Linux PlatformsThe Suggested fix: Either:
P1: Data Size vs Index Calculation MismatchThe benchmark generates 500M rows ( Overall, the benchmark improvements look well-structured and useful for real-world performance testing. Just the platform compatibility issue needs to be addressed before merge. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
5bcbab8 to
493615e
Compare
|
I've addressed P0 from claudes review. I think P1 is fine. 500MB is needed to get 100,000 spaced out rows. We need that many to get a good sense of the timing. |
I've been using this benchmark for a number of potential reader improvements and made it more representative of real world use cases by adding multiple threads, more depth per thread, and a no-cache mode to force the data to be read from disk.
I've been using this benchmark for a number of potential reader improvements and made it more representative of real world use cases by adding multiple threads, more depth per thread, and a no-cache mode to force the data to be read from disk.
I've been using this benchmark for a number of potential reader improvements and made it more representative of real world use cases by adding multiple threads, more depth per thread, and a no-cache mode to force the data to be read from disk.