fix: remove imports that are not needed#5651
Merged
westonpace merged 1 commit intolance-format:mainfrom Jan 7, 2026
Merged
Conversation
Xuanwo
approved these changes
Jan 7, 2026
rpgreen
approved these changes
Jan 7, 2026
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
There is already an `import warnings` at the top of the file. Having the
import inside the if branches actually causes errors because if you have
something like this...
```
import warnings
def some_function():
if something:
import warnings
warnings.warn("blah")
```
You will get an error because the inner import creates a function-local
variable named `warnings` which is undefined when the function starts
and you will get an `UnboundLocalError`. This is currently causing the
benchmarks to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already an
import warningsat the top of the file. Having the import inside the if branches actually causes errors because if you have something like this...You will get an error because the inner import creates a function-local variable named
warningswhich is undefined when the function starts and you will get anUnboundLocalError. This is currently causing the benchmarks to fail.