fix: allow nearest applied in default_scan_options#5666
Merged
yanghua merged 1 commit intolance-format:mainfrom Jan 12, 2026
Merged
fix: allow nearest applied in default_scan_options#5666yanghua merged 1 commit intolance-format:mainfrom
yanghua merged 1 commit intolance-format:mainfrom
Conversation
chenghao-guo
force-pushed
the
fix-defaults_scanoptions
branch
2 times, most recently
from
5f90df5 to
302fdc4
Compare
yanghua
approved these changes
Jan 10, 2026
Collaborator
yanghua
left a comment
yanghua
left a comment
There was a problem hiding this comment.
LGTM. Thanks for contribution!
Signed-off-by: chenghao <landonguo@gmail.com>
chenghao-guo
force-pushed
the
fix-defaults_scanoptions
branch
from
302fdc4 to
7c1fa6e
Compare
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
When default_scan_options passed a nested dict like
` default_scan_options = {
"nearest": {
"column": "vector",
"q": query_vec,
"k": 5,
},
}`
Current setter will fail with "ScannerBuilder.nearest() missing 1
required positional argument: 'q'"
This will fix it.
Signed-off-by: chenghao <landonguo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When default_scan_options passed a nested dict like
default_scan_options = { "nearest": { "column": "vector", "q": query_vec, "k": 5, }, }Current setter will fail with "ScannerBuilder.nearest() missing 1 required positional argument: 'q'"
This will fix it.