feat: make on arg optional for merge insert api#5667
Merged
yanghua merged 2 commits intolance-format:mainfrom Jan 15, 2026
Merged
feat: make on arg optional for merge insert api#5667yanghua merged 2 commits intolance-format:mainfrom
yanghua merged 2 commits intolance-format:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
majin1102
approved these changes
Jan 14, 2026
| def merge_insert( | ||
| self, | ||
| on: Union[str, Iterable[str]], | ||
| on: Optional[Union[str, Iterable[str]]] = None, |
Contributor
There was a problem hiding this comment.
Wondering if the new table doesn't have the same column name of source table pk. How do we deal with such case.
This isn’t about the current PR. Just want to know if this is a reasonable constrait.
Collaborator
Author
There was a problem hiding this comment.
If the source table can not find the same column as the PK. When doing the join action in Data Fusion, it would throw an exception.
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #5652