feat: add order to primary key#5683
Merged
jackye1995 merged 10 commits intolance-format:mainfrom Jan 11, 2026
Merged
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
jackye1995
reviewed
Jan 11, 2026
|
|
||
| </details> | ||
|
|
||
| ### Unenforced Primary Key |
Contributor
There was a problem hiding this comment.
thanks for adding this! I missed it in the doc refresh
Address review feedback to use field_id instead of position for consistency with other specs like partitioning and region specs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
reviewed
Jan 11, 2026
jackye1995
reviewed
Jan 11, 2026
jackye1995
reviewed
Jan 11, 2026
jackye1995
reviewed
Jan 11, 2026
- Add note that primary key is fixed after initial setting - Change "column ordering" to "primary key field ordering" in docs - Simplify inline comments - Update test comments to match doc terminology Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
reviewed
Jan 11, 2026
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
touch-of-grey
changed the title
jackye1995
approved these changes
Jan 11, 2026
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
looks good to me! pending CI
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jackye1995
reviewed
Jan 11, 2026
| To mark a field as part of the primary key, add the following metadata to the Arrow field: | ||
|
|
||
| - `lance-schema:unenforced-primary-key`: Set to `true`, `1`, or `yes` (case-insensitive) to indicate the field is part of the primary key. | ||
| - `lance-schema:unenforced-primary-key:field-id` (optional): A 1-based integer specifying the primary key field id within a composite primary key. |
Contributor
There was a problem hiding this comment.
Sorry for the back and forth, but I think I agree now that position is better than field-id. For partition and region spec, they represent new fields in the spec so spec makes sense. But here it is pretty confusing to have field ID and primary key field ID in the same place. Let's move back to that.
Address review feedback to avoid confusion between "schema field id" and "primary key field id" by using "position" terminology instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use is_unenforced_primary_key() method instead of the removed unenforced_primary_key field. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Java: Add unenforcedPrimaryKeyPosition field and getter to LanceField - Python: Add is_unenforced_primary_key() and unenforced_primary_key_position() methods to LanceField Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
This PR adds ordering to primary key so that it can be used for btree index. This is a part of the work to make the MemTable proposal work after discussion with @jackye1995, and for my use case the primary key has to be multiple. --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ordering to primary key so that it can be used for btree index. This is a part of the work to make the MemTable proposal work after discussion with @jackye1995, and for my use case the primary key has to be multiple. @jackye1995 could you take a look?