feat: support List and Struct type for KeyValue in inserted_rows.rs#5713
Merged
yanghua merged 1 commit intolance-format:mainfrom Jan 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
wojiaodoubao
force-pushed
the
nested-datatype-for-merge-insert-key-value
branch
2 times, most recently
from
172d7c4 to
569289c
Compare
Contributor
Author
|
Hi @yanghua , could you help review this when you have time, thanks very much~ |
yanghua
reviewed
Jan 15, 2026
Collaborator
yanghua
left a comment
yanghua
left a comment
There was a problem hiding this comment.
For the feature, I have no concern. Two suggestions:
- try to reduce the test codes, there are many duplicated snippets we can reduce;
- can we add at least one test case to do an e2e test for the merge insert api(define a pk by using the supported types in this PR that try to support)
wojiaodoubao
force-pushed
the
nested-datatype-for-merge-insert-key-value
branch
from
569289c to
edec2b5
Compare
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
…ance-format#5713) Using List and Struct type as primary key. Co-authored-by: lijinglun <lijinglun@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using List and Struct type as primary key.