perf: cache global BM25 idf per query#5727
Merged
Conversation
Contributor
Code ReviewSummary: This PR caches the BM25 IDF (query weight) per token during search, avoiding redundant computation across partitions. The optimization is straightforward and correct. Assessment: ✅ LGTMThe change correctly separates the BM25 score computation into its two parts:
What's good:
Minor observations (not blocking):
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Xuanwo
approved these changes
Jan 16, 2026
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 21, 2026
this could avoid scanning all partitions for scoring each token, helpful when we have many partitions and long query --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
this could avoid scanning all partitions for scoring each token, helpful when we have many partitions and long query --------- Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this could avoid scanning all partitions for scoring each token, helpful when we have many partitions and long query