Skip to content

feat: support tencent cos#5740

Merged
wjones127 merged 1 commit intolance-format:mainfrom
ztorchan:support-cos
Jan 30, 2026
Merged

feat: support tencent cos#5740
wjones127 merged 1 commit intolance-format:mainfrom
ztorchan:support-cos

Conversation

@ztorchan
Copy link
Copy Markdown
Contributor

@ztorchan ztorchan commented Jan 17, 2026 •
edited
Loading

close #5726

@github-actions github-actions Bot added the enhancement New feature or request label Jan 17, 2026
@ztorchan
Copy link
Copy Markdown
Contributor Author

ztorchan commented Jan 17, 2026

Current support for COS still has room for improvement.

The options for CosConfig in opendal are very limited, so we need to set the disable_config_load option to false to load more configurations from environment variables, such as TENCENTCLOUD_SECURITY_TOKEN and TENCENTCLOUD_REGION.

Next, we need to improve opendal's support for COS configuration and improve lance accordingly.

@ztorchan
Copy link
Copy Markdown
Contributor Author

ztorchan commented Jan 17, 2026 •
edited
Loading

Hi, @Xuanwo @wjones127 @yanghua , please review this PR when you have time, thanks a lot

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ust/lance-io/src/object_store/providers/tencent.rs 28.00% 18 Missing ⚠️

📢 Thoughts on this report? Let us know!

@wjones127 wjones127 self-assigned this Jan 26, 2026
wjones127
wjones127 requested changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, but I think we want to make the name align with cloud provider rather than service acronym.

Comment thread rust/lance/Cargo.toml Outdated
@ztorchan ztorchan requested a review from wjones127 January 28, 2026 01:23
wjones127
wjones127 approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wjones127 wjones127 merged commit 374bf41 into lance-format:main Jan 30, 2026
28 checks passed
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
@ztorchan @vivek-bharathan
feat: support tencent cos (lance-format#5740)
33f6d88 
close lance-format#5726
This was referenced Feb 9, 2026
Closed
Merged
Merged
@andrea-reale andrea-reale mentioned this pull request Mar 30, 2026
Closed
@wellgeneric wellgeneric mentioned this pull request Apr 22, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees

@wjones127 wjones127

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Tencent Cloud COS in Lance

2 participants

@ztorchan @wjones127