Skip to content

fix(lance-linalg): check fp16kernels feature before arch-specific code #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjones127 merged 3 commits into from
Jan 20, 2026
Merged

fix(lance-linalg): check fp16kernels feature before arch-specific code #5747

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7a6397
fix(lance-linalg): Check fp16kernels feature before arch-specific code
durch Jan 18, 2026
8647a7c
fix: move feature check to else branch per review
durch Jan 18, 2026
49fc9b5
Merge branch 'main' into fix-ios-fp16kernels-build-v1.0.1
durch Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion rust/lance-linalg/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,14 @@ fn main() -> Result<(), String> {
build_f16_with_flags("lsx", &["-mlsx"]).unwrap();
build_f16_with_flags("lasx", &["-mlasx"]).unwrap();
} else {
return Err("Unable to build f16 kernels on given target_arch. Please use x86_64 or aarch64 or remove the fp16kernels feature".to_string());
// Only error if fp16kernels was explicitly requested on unsupported platform.
// This allows builds on iOS, Android, etc. when the feature is disabled.
//
// Note: We use CARGO_FEATURE_* env var instead of cfg!() because cfg!()
// checks the build script's features, not the library's features.
if env::var("CARGO_FEATURE_FP16KERNELS").is_ok() {
return Err("Unable to build f16 kernels on given target_arch. Please use x86_64 or aarch64 or remove the fp16kernels feature".to_string());
}
}
Ok(())
}
Expand Down
Loading