fix: fix deletion when using file-object-store://#5760
Merged
westonpace merged 8 commits intolance-format:mainfrom Jan 21, 2026
Merged
fix: fix deletion when using file-object-store://#5760westonpace merged 8 commits intolance-format:mainfrom
westonpace merged 8 commits intolance-format:mainfrom
Conversation
When using file-object-store://, we currently do not delete directories that are empty. This is because the other object stores (such as s3) don't need this. This PR fixes this to explicitly delete the empty directories whe using file-object-store://.
wjones127
approved these changes
Jan 21, 2026
westonpace
approved these changes
Jan 21, 2026
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
I guess I'm not sure what I'd expect as a user. Should it behave exactly as LocalObjectStore (in which case this PR is diverging from expectations) or just behave how we want it to?
I don't feel strongly enough to worry either way barring more input from any users so go for it.
Contributor
Author
The big issue with the current behavior is that it breaks lancedb when using If you want to use |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
majin1102
pushed a commit
to majin1102/lance
that referenced
this pull request
Jan 23, 2026
When using `file-object-store://`, we currently do not delete
directories that are empty. This is because the other object stores
(such as s3) don't need this. This PR fixes this to explicitly delete
the empty directories when using `file-object-store://`.
This fixes a bug where tables appear to be undeletable when using
`file-object-store://`
```
>>> db = lancedb.connect("file-object-store:///tmp/foo")
>>> table = db.create_table("my_table", schema=schema)
>>> db.table_names()
['my_table']
>>> db.drop_table("my_table")
>>> db.table_names()
['my_table']
```
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
When using `file-object-store://`, we currently do not delete
directories that are empty. This is because the other object stores
(such as s3) don't need this. This PR fixes this to explicitly delete
the empty directories when using `file-object-store://`.
This fixes a bug where tables appear to be undeletable when using
`file-object-store://`
```
>>> db = lancedb.connect("file-object-store:///tmp/foo")
>>> table = db.create_table("my_table", schema=schema)
>>> db.table_names()
['my_table']
>>> db.drop_table("my_table")
>>> db.table_names()
['my_table']
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
file-object-store://, we currently do not delete directories that are empty. This is because the other object stores (such as s3) don't need this. This PR fixes this to explicitly delete the empty directories when usingfile-object-store://.This fixes a bug where tables appear to be undeletable when using
file-object-store://