Skip to content

ci: fix version inconsistency and pytorch deprecation warning#5761

Merged
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:fix-ci
Jan 21, 2026
Merged

ci: fix version inconsistency and pytorch deprecation warning#5761
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:fix-ci

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the ci Github Action or Test issues label Jan 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Review

This PR addresses two CI issues:

1. Version inconsistency fix for lance-namespace-datafusion

Issue: The lance-namespace-datafusion crate was missing from .bumpversion.toml, causing it to remain at 2.0.0-beta.9 while the rest of the workspace is at 2.1.0-beta.0.

Fix: Adds the missing bumpversion entry and updates Cargo.lock.

This fix looks correct.

2. PyTorch deprecation warning suppression

P1 Concern - Warning filter placement:

The warning filter is applied globally at module import time, which will suppress this deprecation warning throughout the entire Python process, not just for this module. This is a heavy-handed approach.

Suggestions:

  1. Consider using a context manager around the specific torch.jit.script decorators if feasible
  2. Alternatively, document this global suppression more prominently (e.g., in the module docstring)
  3. Ensure there is a tracking issue for the migration to torch.compile (the TODO comment mentions this)

The fix is acceptable as a quick workaround to unblock CI, but the global warning suppression should be addressed in a follow-up.

@jackye1995 jackye1995 merged commit 32f3877 into lance-format:main Jan 21, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants