ci: fix version inconsistency and pytorch deprecation warning#5761
Merged
jackye1995 merged 1 commit intolance-format:mainfrom Jan 21, 2026
Merged
ci: fix version inconsistency and pytorch deprecation warning#5761jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995 merged 1 commit intolance-format:mainfrom
Conversation
Contributor
PR ReviewThis PR addresses two CI issues: 1. Version inconsistency fix for lance-namespace-datafusionIssue: The lance-namespace-datafusion crate was missing from .bumpversion.toml, causing it to remain at 2.0.0-beta.9 while the rest of the workspace is at 2.1.0-beta.0. Fix: Adds the missing bumpversion entry and updates Cargo.lock. This fix looks correct. 2. PyTorch deprecation warning suppressionP1 Concern - Warning filter placement: The warning filter is applied globally at module import time, which will suppress this deprecation warning throughout the entire Python process, not just for this module. This is a heavy-handed approach. Suggestions:
The fix is acceptable as a quick workaround to unblock CI, but the global warning suppression should be addressed in a follow-up. |
wjones127
approved these changes
Jan 21, 2026
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
…format#5761) https://github.com/lance-format/lance/actions/runs/21189464705/job/60952409705 https://github.com/lance-format/lance/actions/runs/21190703617/job/60956265092 For pytorch, first give this quick fix to let CI continue to work, actual fix is needed to use `torch.compile`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/lance-format/lance/actions/runs/21189464705/job/60952409705
https://github.com/lance-format/lance/actions/runs/21190703617/job/60956265092
For pytorch, first give this quick fix to let CI continue to work, actual fix is needed to use
torch.compile