feat(java): support json extraction by scanning#5770
feat(java): support json extraction by scanning#5770majin1102 merged 2 commits intolance-format:mainfrom
Conversation
Code Review for PR #5770SummaryThis PR adds Java utilities for creating Arrow JSON extension fields and a test to verify JSON extraction via scanning works correctly. P0 IssuesNone identified - The implementation is correct and addresses the issue #5744. P1 Issues / Suggestions
Positive Aspects
VerdictLGTM ✓ - The PR correctly solves the issue and the implementation is clean. The test adequately covers the use case. |
|
@Xuanwo Could you take a look at this json related feat for Java binding? Thanks |
yanghua
left a comment
There was a problem hiding this comment.
Overall, LGTM, left a test suggestion.
| public class JsonExtractionTest { | ||
|
|
||
| @Test | ||
| void testJsonExtraction(@TempDir Path tempDir) throws Exception { |
There was a problem hiding this comment.
Can we add more tests for some corner cases? For example, null field, invalid JSON string, jsonLargeUtf8 .
|
Ready for another look @yanghua |
Close lance-format#5744 For now arrow-java does't provide a convenient way like `pa.json()`. So we extend the field type in lance java binding to support related json udf --------- Co-authored-by: majin.nathan <majin.nathan@bytedance.com>
Close #5744
For now arrow-java does't provide a convenient way like
pa.json(). So we extend the field type in lance java binding to support related json udf