Conversation
PR ReviewSummary: Test stability improvements for FTS result comparison + uv lockfile refresh. P1 Issues1. Potential bug in sort fallback logic ( When 2. dtype=object conversion may mask type mismatches ( Converting all non-score columns to Consider keeping type-aware comparison or at least logging/asserting dtype equality: assert single_df[col].dtype == distributed_df[col].dtype, f"Column {col} dtype mismatch"Minor Observations
Overall the test stability improvements are reasonable, just the type-handling concern above warrants consideration. |
This PR will try to make tests more stable --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will try to make tests more stable --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will try to make tests more stable --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will try to make tests more stable --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This PR will try to make tests more stable
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.