Conversation
Contributor
Code ReviewThis PR exposes the SummaryThe implementation correctly mirrors the existing Rust FeedbackP1 - Missing variant in Python API: The Rust P1 - Test coverage is minimal: The new test only covers the
The implementation itself looks correct and follows the existing patterns. |
wjones127
reviewed
Jan 22, 2026
Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
approved these changes
Jan 22, 2026
Collaborator
Author
|
Thank you @wjones127 for the help of review! |
Collaborator
Author
|
The python lint job should be fixed by #5788 |
jackye1995
pushed a commit
to jackye1995/lance
that referenced
this pull request
Jan 23, 2026
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
majin1102
pushed a commit
to majin1102/lance
that referenced
this pull request
Jan 23, 2026
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
jackye1995
pushed a commit
that referenced
this pull request
Jan 23, 2026
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
Xuanwo
added a commit
that referenced
this pull request
Jan 26, 2026
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
jackye1995
pushed a commit
that referenced
this pull request
Jan 26, 2026
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.** --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will expose blob handling APIs to python so that users can just scan all blobs as binary.
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.