fix: allow unused_unsafe for __cpuid to support both stable and nightly#5793
Merged
jackye1995 merged 1 commit intolance-format:mainfrom Jan 23, 2026
Merged
Conversation
Contributor
Review SummaryLGTM ✓ This is a minimal, correct fix for the Rust nightly compatibility issue where The No concerns with this change. |
In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when RUSTFLAGS includes -D warnings. Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed). Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
force-pushed
the
fix-nightly-cpuid-unsafe
branch
from
4dd8ff7 to
6ca3490
Compare
westonpace
approved these changes
Jan 23, 2026
jackye1995
added a commit
to jackye1995/lance
that referenced
this pull request
Jan 23, 2026
…ly (lance-format#5793) In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when -D warnings is set (e.g., via setup-rust-toolchain action). Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed). Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
majin1102
pushed a commit
to majin1102/lance
that referenced
this pull request
Jan 23, 2026
…ly (lance-format#5793) In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when -D warnings is set (e.g., via setup-rust-toolchain action). Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed). Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
jackye1995
added a commit
that referenced
this pull request
Jan 23, 2026
…ly (#5793) In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when -D warnings is set (e.g., via setup-rust-toolchain action). Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed). Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
…ly (lance-format#5793) In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when -D warnings is set (e.g., via setup-rust-toolchain action). Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed). Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rust nightly, __cpuid was changed to be a safe function, making the unsafe block unnecessary. This causes a warning that fails CI when -D warnings is set (e.g., via setup-rust-toolchain action).
Adding #[allow(unused_unsafe)] allows the code to compile without warnings on both stable (where unsafe is required) and nightly (where it's no longer needed).
Also add RUSTFLAGS="-D warnings" to the linux-build CI job to catch such issues early.
🤖 Generated with Claude Code