Skip to content

ci: fix wikipedia benchmark#5802

Merged
Xuanwo merged 1 commit intomainfrom
luban/hour-private
Jan 26, 2026
Merged

ci: fix wikipedia benchmark#5802
Xuanwo merged 1 commit intomainfrom
luban/hour-private

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Jan 26, 2026

This PR will fix main branch's broken benchmark CI.


Parts of this PR were drafted with assistance from Codex (with gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.

@github-actions github-actions Bot added the ci Github Action or Test issues label Jan 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

LGTM

The fix is correct. The wikipedia.py datagen script imports from datasets import load_dataset to download Wikipedia data from HuggingFace, but the datasets package was missing from the CI pip install step.

No concerns.

@Xuanwo Xuanwo merged commit b2ba977 into main Jan 26, 2026
5 checks passed
@Xuanwo Xuanwo deleted the luban/hour-private branch January 26, 2026 14:36
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
This PR will fix main branch's broken benchmark CI.

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants