Skip to content

ci: fix benchmark regress#5821

Merged
Xuanwo merged 1 commit intomainfrom
luban/royal-pole
Jan 27, 2026
Merged

ci: fix benchmark regress#5821
Xuanwo merged 1 commit intomainfrom
luban/royal-pole

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Jan 27, 2026

This PR will fix benchmark regress


Parts of this PR were drafted with assistance from Codex (with gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.

@github-actions github-actions Bot added python ci Github Action or Test issues labels Jan 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Review

Summary: This PR migrates from the deprecated list_indices() to describe_indices() and improves the data structure from list to set for index name lookup.

Assessment: ✅ LGTM

The changes are correct and appropriate:

  1. list_indices() is deprecated (see python/python/lance/dataset.py:636-650) and describe_indices() is the recommended replacement
  2. Both methods return objects with a .name attribute, so the code remains functionally correct
  3. The change from list comprehension to set comprehension ([...]{...}) improves lookup efficiency for in checks from O(n) to O(1)

No issues identified.

@Xuanwo Xuanwo merged commit b90a430 into main Jan 27, 2026
14 checks passed
@Xuanwo Xuanwo deleted the luban/royal-pole branch January 27, 2026 14:05
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
This PR will fix benchmark regress

---

**Parts of this PR were drafted with assistance from Codex (with
`gpt-5.2`) and fully reviewed and edited by me. I take full
responsibility for all changes.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Github Action or Test issues python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants