Skip to content

fix: improve error messages in FixedSizeListArrayExt::convert_to_floating_point #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjones127 merged 3 commits into from
Feb 23, 2026
Merged

fix: improve error messages in FixedSizeListArrayExt::convert_to_floating_point #5836

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bc23da
init
LuciferYang Jan 28, 2026
0b6b977
Merge branch 'lance-format:main' into fix-convert_to_floating_point-e…
LuciferYang Jan 28, 2026
8e2b1ac
Merge branch 'main' into fix-convert_to_floating_point-error-msg
wjones127 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rust/lance-arrow/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ impl FixedSizeListArrayExt for FixedSizeListArray {
.as_any()
.downcast_ref::<Int16Array>()
.ok_or(ArrowError::ParseError(
"Fail to cast primitive array to Int8Type".to_string(),
"Fail to cast primitive array to Int16Type".to_string(),
))?
.into_iter()
.filter_map(|x| x.map(|y| y as f32)),
Expand All @@ -339,7 +339,7 @@ impl FixedSizeListArrayExt for FixedSizeListArray {
.as_any()
.downcast_ref::<Int32Array>()
.ok_or(ArrowError::ParseError(
"Fail to cast primitive array to Int8Type".to_string(),
"Fail to cast primitive array to Int32Type".to_string(),
))?
.into_iter()
.filter_map(|x| x.map(|y| y as f32)),
Expand All @@ -358,7 +358,7 @@ impl FixedSizeListArrayExt for FixedSizeListArray {
.as_any()
.downcast_ref::<Int64Array>()
.ok_or(ArrowError::ParseError(
"Fail to cast primitive array to Int8Type".to_string(),
"Fail to cast primitive array to Int64Type".to_string(),
))?
.into_iter()
.filter_map(|x| x.map(|y| y as f64)),
Expand All @@ -377,7 +377,7 @@ impl FixedSizeListArrayExt for FixedSizeListArray {
.as_any()
.downcast_ref::<UInt8Array>()
.ok_or(ArrowError::ParseError(
"Fail to cast primitive array to Int8Type".to_string(),
"Fail to cast primitive array to UInt8Type".to_string(),
))?
.into_iter()
.filter_map(|x| x.map(|y| y as f64)),
Expand All @@ -396,7 +396,7 @@ impl FixedSizeListArrayExt for FixedSizeListArray {
.as_any()
.downcast_ref::<UInt32Array>()
.ok_or(ArrowError::ParseError(
"Fail to cast primitive array to Int8Type".to_string(),
"Fail to cast primitive array to UInt32Type".to_string(),
))?
.into_iter()
.filter_map(|x| x.map(|y| y as f64)),
Expand Down
Loading