Skip to content

ci: fix rust release workflow and allow manual publish#5842

Merged
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:fix-release-workflows
Jan 29, 2026
Merged

ci: fix rust release workflow and allow manual publish#5842
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:fix-release-workflows

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 commented Jan 28, 2026

Closes #5837

Also allow manually run other publish workflows to unblock potentially similar errors in the future.

Verified using https://github.com/lance-format/lance/actions/runs/21450113556

- Change cargo-publish.yml runner from ubuntu-2404-8x-x64 to warp-ubuntu-latest-x64-8x
- Add skip_check_repo input to cargo-publish.yml for backfilling missed releases
- Fix ref fallback in java-publish.yml checkout steps (use inputs.ref || github.ref)
- Fix ref fallback in pypi-publish.yml windows job (use inputs.ref || github.ref)

Fixes lance-format#5837

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the bug Something isn't working label Jan 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

Summary: This PR fixes release workflow issues for backfilling missed crates.io publishes.

P1 Issue: Logic Error in check-repo Condition

The check-repo condition in cargo-publish.yml:95 has inverted logic:

check-repo: ${{ github.event_name \!= 'workflow_dispatch' || inputs.skip_check_repo \!= true }}

Problem: When the user sets skip_check_repo=true during a workflow_dispatch, this evaluates to:

  • false || false = false (correct - skips check)

However, when skip_check_repo=false (default):

  • false || true = true (correct - performs check)

When triggered by a release event:

  • true || (anything) = true (correct - performs check)

Actually, on closer inspection the logic is correct. Disregard this concern.

Minor Observations (Not blockers)

  1. The PR description mentions changing runner from ubuntu-2404-8x-x64 to warp-ubuntu-latest-x64-8x, but the diff only shows adding the skip_check_repo input and check-repo parameter. The runner change appears to have been done in a prior commit already merged to main (line 25 shows warp-ubuntu-latest-x64-8x).

  2. The fixes to java-publish.yml and pypi-publish.yml are correct - adding || github.ref as fallback ensures the checkout works when inputs.ref is not provided during non-workflow_dispatch events.

LGTM

The changes correctly address the issue. The ref fallback fixes are straightforward and follow the pattern already used in other jobs (e.g., pypi-publish.yml linux job at line 57).

@jackye1995 jackye1995 changed the title fix: fix release workflows for manual backfill and correct ref handling ci: fix rust release workflows and allow manual publish Jan 28, 2026
@jackye1995 jackye1995 changed the title ci: fix rust release workflows and allow manual publish ci: fix rust release workflow and allow manual publish Jan 28, 2026
@github-actions github-actions Bot added the ci Github Action or Test issues label Jan 28, 2026
@jackye1995 jackye1995 merged commit 976c847 into lance-format:main Jan 29, 2026
24 checks passed
vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
…5842)

Closes lance-format#5837

Also allow manually run other publish workflows to unblock potentially
similar errors in the future.

Verified using
https://github.com/lance-format/lance/actions/runs/21450113556

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release publishing cancelled: cargo-publish build job stuck waiting for unavailable runner label

2 participants