fix(java): panic when reading CreateIndex transaction#5853
Merged
wjones127 merged 2 commits intolance-format:mainfrom Jan 30, 2026
Merged
fix(java): panic when reading CreateIndex transaction#5853wjones127 merged 2 commits intolance-format:mainfrom
wjones127 merged 2 commits intolance-format:mainfrom
Conversation
Contributor
Code ReviewSummary: This PR adds support for reading Assessment: LGTM ✓The implementation correctly:
Minor note (non-blocking)The PR title says "throw panic when read CreateIndex transaction" but the fix actually prevents the panic by handling the case properly. Consider updating the title to "fix: panic when reading CreateIndex transaction" for clarity. Reviewed with Claude Code |
majin1102
changed the title
westonpace
approved these changes
Jan 30, 2026
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Looks straightforward to me. Thanks for the addition!
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
) Close lance-format#5852 The panic is because the underlying read transaction didn't handle `CreateIndex` operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #5852
The panic is because the underlying read transaction didn't handle
CreateIndexoperation