fix: fix mini-block dictionary bitpacking panic#5860
Merged
Conversation
Handle bitpacking dictionary encodings in MiniBlockScheduler and add regression tests.
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Contributor
Code ReviewOverall Assessment: This is a well-structured bug fix that addresses a real panic when using mini-block dictionary encoding with bitpacking compression. Positive Aspects
P1: Minor Issues
Suggestions (non-blocking)
Automated review by Claude |
BubbleCal
approved these changes
Jan 30, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
Fix a panic in mini-block dictionary decode when the dictionary buffer uses bitpacking encodings. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.2`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a panic in mini-block dictionary decode when the dictionary buffer uses bitpacking encodings.
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.